Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interplay; publish from Tavis to Bintray #92

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

ennru
Copy link
Contributor

@ennru ennru commented Jun 29, 2020

  • Independent of Interplay
  • Release via Bintray

Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with a minor, non-blockign suggestion)

.travis.yml Outdated
language: scala

before_install: curl -Ls https://git.io/jabba | bash && . ~/.jabba/jabba.sh
before_install: curl -Ls https://raw.githubusercontent.com/shyiko/jabba/0.11.2/install.sh | bash && . ~/.jabba/jabba.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the version with retries we're adopting in other places? (https://github.com/akka/akka-projection/pull/289/files, lagom/lagom#2908,...)

 - if [ ! -f ~/.jabba/jabba.sh ]; then curl -L -v --retry 5 -o jabba-install.sh https://raw.githubusercontent.com/shyiko/jabba/0.11.2/install.sh && bash jabba-install.sh; fi
  - . ~/.jabba/jabba.sh

@ennru ennru merged commit 420827f into playframework:master Jun 29, 2020
@ennru ennru deleted the no-interplay branch June 29, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants