-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub actions #415
Migrate to GitHub actions #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things. Please also remove the travis status check from the repo settings and add the "Finish / Ready To Merge" one instead.
Actually this project does not have sbt-ci-release
set up already, so this needs to be done as well... (It was/is my plan to set that up for every repo as soon as Sergey reviewed and merged GHA pull request in the .github repo, since that is the final piece for me that is missing to go through each repo and correctly set up GHA everywhere, including sb-ci-release.)
jobs: | ||
include: | ||
- stage: publish | ||
script: sbt ++2.12.15 publish ++2.13.8 "project play-grpc-generators; set publish/skip := true; project play-grpc" publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this set publish/skip...
should actually be configured in build.sbt
itself. Also probably we should make sure we only call publish for the play-grpc
project? Or maybe configure the build correctly so that only publish
will do... I have to check tomorrow as I am to tired now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, play-grpc
seems to be the aggregate rule. There are several projects that look like they are published, if you run publish
from the aggregate:
- "play-grpc-runtime"
- "play-grpc-testkit"
- "play-grpc-specs2"
- "play-grpc-scalatest"
- "lagom-javadsl-grpc-testkit"
- "lagom-scaladsl-grpc-testkit"
Many of them seem viable to eventually publish. For instance, having separate modules for test suites feels like a reasonable thing to do. But I guess this project is still somewhat in flight.
I added the build.play.grpc.NoPublish
to play-grpc-generators
, since it's skipped in the travis rule. It also feels like it could be useful to publish, but better to keep things as-is for now I guess.
Done.
If we're waiting on some common work to be finished, I can cut another PR once that work is complete. Not having checks prevents us from doing scala-steward merges though, which I think are important. |
These tests are quite flakey. Might need to take a pass at stabilizing them soon. |
playframework/.github/
workflows to run tests.scalafmt
.Notes:
.github
keys/secrets, but it needs to be tested.travis.yml
, because tests failed with more recent versions.