Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The funny thing is
is not ported to Pekko gRPC yet 🤣 so we end up with the
IllegalArgumentException: "ALPN must be enabled and list HTTP/2 as a supported protocol"
here as well.For this PR good news is that if we would comment out
play-grpc/play-specs2/src/test/scala/play/grpc/specs2/PlaySpecs2Spec.scala
Lines 67 to 72 in deeea2e
play-grpc/play-scalatest/src/test/scala/play/grpc/scalatest/PlayScalaTestSpec.scala
Lines 65 to 68 in deeea2e
play-grpc/play-scalatest/src/test/scala/play/grpc/scalatest/PlayActionsScalaTestSpec.scala
Lines 67 to 70 in deeea2e
play-grpc/play-testkit/src/test/java/play/grpc/testkit/PlayJavaFunctionalTest.java
Lines 84 to 101 in deeea2e
it should become green.
This PR also switched groupId to
org.playframework
.TODO:
docs/
folder