Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Play 3 and Pekko #490

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Switch to Play 3 and Pekko #490

merged 6 commits into from
Dec 21, 2023

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Dec 21, 2023

The funny thing is

is not ported to Pekko gRPC yet 🤣 so we end up with the IllegalArgumentException: "ALPN must be enabled and list HTTP/2 as a supported protocol" here as well.

For this PR good news is that if we would comment out

it should become green.

This PR also switched groupId to org.playframework.

TODO:

  • Everything inside the docs/ folder

@mkurz
Copy link
Member Author

mkurz commented Dec 21, 2023

@ihostage What do you think about the ALPN thing? Funny or not?

@ihostage
Copy link
Member

is not ported to Pekko gRPC yet 🤣

It was a predictable 😂

@mkurz
Copy link
Member Author

mkurz commented Dec 21, 2023

@ihostage You want to open an issue?

@mkurz
Copy link
Member Author

mkurz commented Dec 21, 2023

Pushed a commit to see if CI turns green ignoring the ALPN problem.

@ihostage
Copy link
Member

@ihostage You want to open an issue?

I want an open PR, because It will be more quickly win strategy for us 😄

Copy link
Contributor

@sentenza sentenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz @ihostage Thank you so much for jumping onto this Play3 PR so quickly!

@mkurz perhaps commenting out those 4 tests while waiting for the next Pekko gRPC version is not the end of the world. Probably it would be worth to add a specific note in the README with a related TODO list.

docs/modules/ROOT/pages/gradle-support.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
@mkurz mkurz force-pushed the pekko branch 2 times, most recently from 71abc1b to 7fab605 Compare December 21, 2023 19:42
@mkurz
Copy link
Member Author

mkurz commented Dec 21, 2023

Let's merge this so we can continue, we can enable the tests in another PR.

@mkurz mkurz merged commit 9c9d35a into playframework:main Dec 21, 2023
8 checks passed
@mkurz mkurz deleted the pekko branch December 21, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants