adjust JsonMemoryFootprintSpec for Scala 2.13.10 as used by Scala 3 #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@htmldoug |
htmldoug
approved these changes
Oct 17, 2022
|
That's good to hear! I'll close this PR for now since there isn't yet a proper Scala 3 release that needs it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at present, Scala 3 uses the Scala 2.13.8 standard library. I am working on a PR (scala/scala3#16074) to upgrade it to 2.13.10. in CI, play-json failed in the community build after the version bump
here in this PR, I've blindly updated the numbers to make the test pass again, but I don't actually know what the cause for the change might have been. so I'm looking for your confirmation that there isn't some cause for concern here