Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #836 - Scala3 macro nesting class #956

Merged

Conversation

cchantep
Copy link
Member

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Fixes #836

Purpose

Nesting class support for Scala 3 macros

@mkurz mkurz force-pushed the fix/836_scala3_macro_nesting_class branch from 3e20746 to 1b2c379 Compare January 16, 2024 22:33
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkurz mkurz merged commit 65ff128 into playframework:main Jan 16, 2024
14 checks passed
@mkurz
Copy link
Member

mkurz commented Jan 16, 2024

@Mergifyio backport 2.10.x

Copy link
Contributor

mergify bot commented Jan 16, 2024

backport 2.10.x

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jan 16, 2024
[2.10.x] Fix #836 - Scala3 macro nesting class (backport #956) by @cchantep
@cchantep cchantep deleted the fix/836_scala3_macro_nesting_class branch January 17, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException while executing macro expansion on Scala3
2 participants