Upgrading Play framework to 2.9.0

[MathisGuillet1]

Pull Request Checklist

• Have you read How to write the perfect pull request?
• Have you read through the contributor guidelines?
• Have you added copyright headers to new files?
• Have you suggest documentation edits?
• Have you added tests for any changed functionality?

Fixes

Fixes #39

Purpose

What does this PR do?

Upgrade silhouette to a Play 2.9 baseline (and its requirements).
See play 2.9 migration guide: https://www.playframework.com/documentation/2.9.x/Migration29
Also, this PR aligns silhouette dependencies with play dependencies versions.

Background Context

Why did you take this approach?

When trying to update to play framework to 2.9.x, I am facing silhouette runtime errors like the following :

Exception in thread ... java.lang.NoSuchMethodError: 'void play.api.mvc.Result.<init>(play.api.mvc.ResponseHeader, play.api.http.HttpEntity, scala.Option, scala.Option, scala.collection.immutable.Seq)'
	at io.github.honeycombcheesecake.play.silhouette.api.services.AuthenticatorResult.<init>(AuthenticatorService.scala:47)
	at io.github.honeycombcheesecake.play.silhouette.api.services.AuthenticatorResult$.apply(AuthenticatorService.scala:80)
       ...

Seems like binary compatibility issues. Upgrading the silhouette's play dependency seems to fix the issue.

References

Are there any relevant issues / PRs / mailing lists discussions?

[mkurz]

@MathisGuillet1 please check you inbox, I invited you to the playframework organization and you should then also be maintainer of this repo.

[coveralls]

Pull Request Test Coverage Report for Build 6930419047

• 10 of 10 (100.0%) changed or added relevant lines in 7 files are covered.
• 14 unchanged lines in 10 files lost coverage.
• Overall coverage decreased (-0.4%) to 94.118%

---

Files with Coverage Reduction	New Missed Lines	%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/impl/authenticators/CookieAuthenticator.scala	1	98.96%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/impl/providers/oauth2/Auth0Provider.scala	1	86.67%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/impl/providers/OpenIDProvider.scala	1	93.33%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/impl/providers/state/CsrfStateItemHandler.scala	1	84.0%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/impl/services/GravatarService.scala	1	90.91%
silhouette-crypto-jca/src/main/scala/io/github/honeycombcheesecake/play/silhouette/crypto/JcaSigner.scala	1	95.83%
silhouette-totp/src/main/scala/io/github/honeycombcheesecake/play/silhouette/impl/providers/GoogleTotpProvider.scala	1	87.5%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/impl/authenticators/SessionAuthenticator.scala	2	96.23%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/impl/providers/openid/services/PlayOpenIDService.scala	2	11.11%
silhouette/app/io/github/honeycombcheesecake/play/silhouette/api/ErrorHandler.scala	3	57.89%

Totals
Change from base Build 6929186658:	-0.4%
Covered Lines:	1360
Relevant Lines:	1445

---

💛 - Coveralls

[mkurz]

Boom, it's green 😄 But I will take another look before merging...

[MathisGuillet1]

Any specific reason for this version upgrade ?

[MathisGuillet1]

Boom, it's green 😄 But I will take another look before merging...

Anything missing before the merge ? Can I help on something ?

[wjglerum]

Boom, it's green 😄 But I will take another look before merging...

nice work! thanks for moving this project here, when are you planning to release a new version based on Play 2.9/3.0? This is the only lib blocking the upgrade now that you released an updated version of Play Slick last week 👍