Make dbConfig lazy to fix Scala 3 error #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, the making this field lazy was added in #416 |
However since in Scala 2 "lazy values may not be abstract" we need to make it non-abstract with ???. Not the nicest thing to do, but ok...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However since in Scala 2 "lazy values may not be abstract" we need to make it non-abstract with ???. Not the nicest thing to do, but ok...
The reason why I want to get rid of
-source:3.0-migrationis because https://github.com/playframework/omnidoc tries to generate scaladocs from play-slick and to do that for Scala 3 we need to actually compile the sources. Now when adding-source:3.0-migrationin omnidoc a lot of other compiler errors occur from other classes (that are not part of play-slick)