Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1.x] Migrate to GitHub Actions #642

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[2.1.x] Migrate to GitHub Actions #642

merged 1 commit into from
Jan 20, 2022

Conversation

ihostage
Copy link
Member

No description provided.

@ihostage ihostage closed this Jan 20, 2022
@ihostage ihostage reopened this Jan 20, 2022
@ihostage ihostage changed the title [DON'T MERGE] Check GA for 2.1.x [2.1.x] Migrate to GitHub Actions Jan 20, 2022
@ihostage ihostage mentioned this pull request Jan 20, 2022
Closed
23 tasks
@ihostage ihostage requested a review from mkurz January 20, 2022 18:41
mkurz
mkurz approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically that is a copy from the workflow from the main branch, but without the if conditions to determine branches? (Like if: ${{ github.base_ref != '2.1.x' }}...)

@ihostage
Copy link
Member Author

@mkurz Yes. I'll fix main branch too.

@ihostage ihostage merged commit 410f114 into playframework:2.1.x Jan 20, 2022
@ihostage ihostage deleted the check-ga-for-21x branch January 20, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihostage @mkurz