Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to exclude DocViewer in dev mode #1103

Closed
asolntsev opened this issue Feb 10, 2017 · 1 comment
Closed

Make it possible to exclude DocViewer in dev mode #1103

asolntsev opened this issue Feb 10, 2017 · 1 comment
Assignees
@asolntsev
Labels
has-pr
Milestone
1.5.0

Comments

@asolntsev
Copy link
Contributor

Currently Play always adds docviewer module in dev mode.
But I want to optimize my application as much as possible, excluding whatever possible.
I don't really need docviewer - I can read documentation in internet.

I suggest to make decviewer module optionally includable - as all other modules.
@asolntsev asolntsev added this to the 1.5.0 milestone Feb 10, 2017
@asolntsev asolntsev self-assigned this Feb 10, 2017
asolntsev added a commit to codeborne/play that referenced this issue Feb 10, 2017
@asolntsev
Fixes playframework#1103 do not include docviewer module by default
7f52256 
now it can be added to any application in dependencies.yml - as any other module
@asolntsev
Copy link
Contributor Author

See pull request #1104

asolntsev added a commit that referenced this issue Feb 13, 2017
@asolntsev
Merge pull request #1104 from codeborne/exclude-docviewer
14c2d07 
Fixes #1103 do not include `docviewer` module by default
naku added a commit to sismics/play-playful that referenced this issue Apr 29, 2019
@naku
v1.5.0
f7d24c1 
- Upgrade to Play 1.5.3
- Disable Illegal Access warning (with Java 9+)
- Remove DisableDocViewer plugin (already fixed in playframework/play1#1103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asolntsev asolntsev

Labels
has-pr
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@asolntsev