Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary class of Groovy template is output directly under application dir #1403

Closed
holajsh opened this issue Apr 19, 2022 · 0 comments · Fixed by #1406
Closed

Temporary class of Groovy template is output directly under application dir #1403

holajsh opened this issue Apr 19, 2022 · 0 comments · Fixed by #1406
Labels
defect
Milestone
1.7.1

Comments

@holajsh
Copy link
Contributor

holajsh commented Apr 19, 2022

Play Version (1.5.x / etc)

1.7.0

Operating System (Ubuntu 15.10 / MacOS 10.10 / Windows 10)

Debian GNU/Linux Bullseye/Ubuntu 20.04.4 LTS

JDK (Oracle 1.8.0_72, OpenJDK 1.8.x, Azul Zing)

openjdk version "11.0.13" 2021-10-19
OpenJDK Runtime Environment (build 11.0.13+8-post-Debian-1deb11u1)
OpenJDK 64-Bit Server VM (build 11.0.13+8-post-Debian-1deb11u1, mixed mode, sharing)

Expected Behavior

This is a followup on #1354 as I am not able to reopen this issue.
The same problem is still present in Play version 1.7.0 and prevent from using properly this version in a production deployment context where the JVM does not have write access to the root of the application.

Feel free to reopen #1354 and close this ticket.
holajsh added a commit to holajsh/play1 that referenced this issue Apr 21, 2022
@holajsh
[playframework#1403] 🐛 Fix Groovy compilation unit that tries to writ…
5d057d4 
…e in application root folder

* Restore the old reflection code that completely replace the OUTPUT phase of Groovy compilation unit
* Fix the compilation exception handling that was producing cast error as not checking properly exception type
@holajsh holajsh mentioned this issue Apr 21, 2022
Merged
holajsh added a commit to holajsh/play1 that referenced this issue Apr 21, 2022
@holajsh
[playframework#1403] 🐛 Add a comment to explain why reflection is use…
1dbaf5c 
…d instead of Groovy native methods
xael-fry added a commit that referenced this issue Apr 23, 2022
@xael-fry
Merge pull request #1406 from holajsh/1403_groovy_compilation_fixes
ed2622d 
[#1403] 🐛 Fix Groovy compilation unit that tries to write in applicat…
@xael-fry xael-fry added this to the 1.7.1 milestone Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
1.7.1
Development

Successfully merging a pull request may close this issue.

[#1403] 🐛 Fix Groovy compilation unit that tries to write in applicat… holajsh/play1
2 participants
@xael-fry @holajsh