Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2089] the missing upgrade for bouncycastle #1146

Closed
wants to merge 1 commit into from
Closed

[#2089] the missing upgrade for bouncycastle #1146

wants to merge 1 commit into from

Conversation

flybyray
Copy link
Contributor

Related ticket: Upgrade dependencies

@flybyray flybyray force-pushed the lighthouse-2089-missing-bouncycastle branch from 6306aef to c46a8a1 Compare May 25, 2017 10:07
@flybyray flybyray mentioned this pull request May 25, 2017
Merged
@flybyray
Copy link
Contributor Author

there is no real testcode for SSL now. maybe we should add some

@flybyray flybyray changed the title the missing upgrade for bouncycastle [#2089] the missing upgrade for bouncycastle May 25, 2017
@flybyray
Copy link
Contributor Author

do not merge,
just added test case in local development with this error

@@@@ TIMEOUT ! 09:04:42,988 ERROR ~ Failed to initialize PEMKeyManager from file conf/host.key java.lang.ClassCastException: org.bouncycastle.cert.X509CertificateHolder cannot be cast to java.security.cert.X509Certificate at play.server.ssl.SslHttpServerContextFactory$PEMKeyManager.<init>(SslHttpServerContextFactory.java:108) at play.server.ssl.SslHttpServerContextFactory$PEMKeyManager.<clinit>(SslHttpServerContextFactory.java:83)

The object ((PEMParser) reader).readObject() is now org.bouncycastle.cert.X509CertificateHolder and there is no way to cast or get a java.security.cert.X509Certificate from it.

@flybyray
Copy link
Contributor Author

#1159 fixes errors and adds tests

@flybyray flybyray closed this May 31, 2017
xael-fry added a commit to xael-fry/play that referenced this pull request Jul 14, 2023
@xael-fry
[playframework#1146] test(python): use python 3 for build instead of …
fa1f7a9 
…deprecated python2
xael-fry added a commit that referenced this pull request Jul 15, 2023
@xael-fry
Merge pull request #1447 from xael-fry/1446_remove-python2.x
c0e166c 
[#1146] test(python): use python 3 for build instead of deprecated python2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flybyray