Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loaded entity classes in hibernate from #1114 #1155

Merged
merged 1 commit into from
Jun 1, 2017
Merged

fix loaded entity classes in hibernate from #1114 #1155

merged 1 commit into from
Jun 1, 2017

Conversation

flybyray
Copy link
Contributor

revert ApplicationClassloader changes from #1114
fixing the real entity class loading problem

@flybyray flybyray mentioned this pull request May 29, 2017
Merged
@flybyray
Copy link
Contributor Author

maybe a python test in samples-and-tests/i-am-a-developer could proof that the case of
#1154 #1155 is checked.
should be very easy in that sample project.
If this test would be a good idea, I would add it to this PR

@asolntsev
Copy link
Contributor

@flybyray I like the idea. Let's revert my classloader changes.
Yes, it would be great if you improve a python test in samples-and-tests/i-am-a-developer, but it's not urgent. It can be done in a separate PR.

@xael-fry I suggest to merge this PR. What do you think?

@asolntsev asolntsev self-assigned this May 30, 2017
@asolntsev asolntsev added this to the 1.5.0 milestone May 30, 2017
@asolntsev asolntsev requested a review from xael-fry May 30, 2017 15:18
xael-fry
xael-fry approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@xael-fry xael-fry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer this way

@asolntsev asolntsev merged commit bd21d52 into playframework:master Jun 1, 2017
@asolntsev
Copy link
Contributor

@flybyray @xael-fry Thank you! Merged to master.

@flybyray flybyray mentioned this pull request Jun 1, 2017
Merged
@flybyray flybyray deleted the fix-pull1114 branch June 4, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xael-fry xael-fry xael-fry approved these changes

Assignees

@asolntsev asolntsev

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@flybyray @asolntsev @xael-fry