Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2124] fix(python): add missing unitest lib #1178

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

xael-fry
Copy link
Member

@xael-fry xael-fry commented Aug 23, 2017

@xael-fry xael-fry added this to the 1.5.0 milestone Aug 23, 2017
@xael-fry xael-fry self-assigned this Aug 23, 2017
@xael-fry xael-fry requested a review from asolntsev August 23, 2017 13:24
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xael-fry Do I correctly understand that you want to add some 3rd-party Python testing framework to Play?

Is it really a good idea?

  • Can't we just "import" this library (like we add dependencies in Java projects)?
  • Who will be responsible for keeping this library up-to-date?

@xael-fry
Copy link
Member Author

It is not a 3rd-party lib, it is an optional module of python 2.7 present in installer.
So I don see any problem here

@asolntsev
Copy link
Contributor

@xael-fry I still don't understand :)
But if you don't see problems, we can merge it.

@xael-fry
Copy link
Member Author

The lib was present before, but I accidentally remove it wen updating python.
As it is a Python package lib, we just need to keep update python

@xael-fry xael-fry merged commit 868c971 into master Aug 31, 2017
@xael-fry xael-fry deleted the 2124_uniTestModuleImport branch August 31, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants