[#1849] restore checks in TransactionalJPATest that were accidentally deleted in PR 1246 #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deleted in PR 1246
P.S. it implements my comments for PR playframework#1246
* [#1849] improve design of BinaryTest
P.S. it implements my comments for PR playframework#1246
* [#1849] add method assertIsStaticFile() and special case allowing to test RenderStatic in functional tests
P.S. it implements my comments for PR playframework#1246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.S. it implements my comments for PR #1246
P.S. it implements my comments for PR [#1849] Exceptions from controllers are not detected in FunctionalTests #1246
P.S. it implements my comments for PR [#1849] Exceptions from controllers are not detected in FunctionalTests #1246
cf #1849, #1246, #1248