Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample upgrade for issue #1263 #1266

Merged
merged 1 commit into from
Oct 24, 2018
Merged

sample upgrade for issue #1263 #1266

merged 1 commit into from
Oct 24, 2018

Conversation

flybyray
Copy link
Contributor

No description provided.

@flybyray flybyray mentioned this pull request Sep 12, 2018
Closed
@asolntsev asolntsev self-requested a review September 12, 2018 19:55
@asolntsev asolntsev self-assigned this Sep 12, 2018
asolntsev
asolntsev approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xael-fry Approved this PR. Recommended to merge.

@flybyray
Copy link
Contributor Author

I just checked the other offical dependencies of hibernate 5.3.6.Final
image

I think we need to adjust some other dependencies in play1 too.

@xael-fry xael-fry merged commit 923f091 into playframework:master Oct 24, 2018
@xael-fry
Copy link
Member

Merged thanks @flybyray

@xael-fry xael-fry added this to the 1.5.2 milestone Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xael-fry xael-fry xael-fry approved these changes

@asolntsev asolntsev asolntsev approved these changes

Assignees

@asolntsev asolntsev

Labels
feature
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@flybyray @xael-fry @asolntsev