Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 11 (JDT update) #1292

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Java 11 (JDT update) #1292

merged 3 commits into from
Feb 1, 2019

Conversation

sbeigel
Copy link
Contributor

@sbeigel sbeigel commented Jan 18, 2019

Get ready for Java 11: JDT updated, option for Java source version 11 added

@sbeigel
Copy link
Contributor Author

sbeigel commented Jan 18, 2019

Ah, I'm afraid it's not that simple :) I think we have to update ASM to version 7.0 and to (re-)patch javaflow to make this work...

@tomparle
Copy link
Contributor

Thank you for the contribution Sebastian !
Indeed, the latest version of asm offers better support for the JDK 11, with some welcomed fixes, so it's a good thing to have upgraded it too !

@sbeigel
Copy link
Contributor Author

sbeigel commented Jan 21, 2019

It's all green for me now, Java 11 source ist (pre-)compiled successfully, my web apps do work. I think together with my other PRs (mainly the hibernate 5.4 update) we should be ready for Java 11 :)

I'd appreciate if you could test a little bit as well and if it's all good, merge this stuff so we can all move to Java 11 ;)

@xael-fry xael-fry self-requested a review January 21, 2019 10:15
@xael-fry xael-fry added this to the 1.5.3 milestone Jan 21, 2019
@sbeigel
Copy link
Contributor Author

sbeigel commented Jan 31, 2019

To avoid conflicts, I rebased on master after the hibernate 5.4 changes got merged.

@xael-fry xael-fry merged commit 41f821f into playframework:master Feb 1, 2019
@xael-fry
Copy link
Member

xael-fry commented Feb 1, 2019

Merged and pushed in master
Thanks all @sbeigel @asolntsev ...

@jacol84 jacol84 mentioned this pull request Feb 8, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xael-fry xael-fry xael-fry approved these changes

@asolntsev asolntsev asolntsev approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sbeigel @tomparle @xael-fry @asolntsev