Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1502] JPA/Hibernate warns about use of deprecated positional parameter #504

Merged
merged 1 commit into from
May 6, 2012
Merged

[#1502] JPA/Hibernate warns about use of deprecated positional parameter #504

merged 1 commit into from
May 6, 2012

Conversation

marcelmay
Copy link
Contributor

  • Fixes JPA parameter binding by replacing '?' with '?1' (or whatever the index)
  • Replaced query string catenation with StringBuilder

- Fixes JPA parameter binding by replacing '?' with '?1' (or whatever the index)
- Replaced query string catenation with StringBuilder
pepite added a commit that referenced this pull request May 6, 2012
[#1502] JPA/Hibernate warns about use of deprecated positional parameter
@pepite pepite merged commit b6797a1 into playframework:master May 6, 2012
@pepite
Copy link
Contributor

pepite commented May 6, 2012

Thanks

pepite added a commit that referenced this pull request May 6, 2012
[#1502] JPA/Hibernate warns about use of deprecated positional parameter
@xael-fry xael-fry mentioned this pull request May 6, 2012
xabolcs added a commit to xabolcs/play1 that referenced this pull request Jan 4, 2021
…om old_master to master

Commit b91659a
("[playframework#878] Add OrderBy support in simplified queries") was never ported
to master.

The changes from Pull Request playframework#504 touched some parts of it,
therefore half of the OrderBy change sneaked in to the "new" master.

Fixing by removing the irrelevant OrderBy change.

In method findByToJPQL in file framework/src/play/db/jpa/JPQL.java:
- old_master merge commit has only StringBuilder related change
- master "merge" commit has this OrderBy change too

old_master merge commit: b6797a1
ported master commit: 97c54d2

Fix: 97c54d2 ("Merge pull request playframework#504 from marcelmay/lighthouse-1502-patch")
xabolcs added a commit to xabolcs/play1 that referenced this pull request Jan 4, 2021
…om old_master to master

Commit b91659a
("[playframework#878] Add OrderBy support in simplified queries") was never ported
to master.

The changes from Pull Request playframework#504 touched some parts of it,
therefore half of the OrderBy change sneaked in to the "new" master.

Fixing by removing the irrelevant OrderBy change.

In method findByToJPQL in file framework/src/play/db/jpa/JPQL.java:
- old_master merge commit has only StringBuilder related change
- master "merge" commit has this OrderBy change too

old_master merge commit: b6797a1
ported master commit: 97c54d2

Fix: 97c54d2 ("Merge pull request playframework#504 from marcelmay/lighthouse-1502-patch")
xabolcs added a commit to xabolcs/play1 that referenced this pull request Mar 23, 2022
…om old_master to master

Commit b91659a
("[playframework#878] Add OrderBy support in simplified queries") was never ported
to master.

The changes from Pull Request playframework#504 touched some parts of it,
therefore half of the OrderBy change sneaked in to the "new" master.

Fixing by removing the irrelevant OrderBy change.

In method findByToJPQL in file framework/src/play/db/jpa/JPQL.java:
- old_master merge commit has only StringBuilder related change
- master "merge" commit has this OrderBy change too

old_master merge commit: b6797a1
ported master commit: 97c54d2

Fix: 97c54d2 ("Merge pull request playframework#504 from marcelmay/lighthouse-1502-patch")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants