[#1849] Exceptions from controllers are not detected in FunctionalTests #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 25, 2015 14:27
xael-fry
changed the title
|
What is holding this PR up? This would fix a number of issues we're having using Functional tests. We have seen many times where our tests pass but actually an exception was thrown by the API which should have resulted in a 500 error. |
|
@xael-fry @Fraserhardy @hsch This PR has some conflicts. Is anybody going to resolve them? |
|
@asolntsev I can't actually see these conflicts. Is this an old travis message? |
|
@Fraserhardy No, this is current status of github issue that you can see right on THIS page:
|
|
The changes from this pr have been moved over to a new branch with conflicts and tests resolved. Please see #1246 for latest PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthouse #1849 from PR #778