Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wildcard import for Helpers in ScalaFunctionalTestSpec #278

Merged
merged 1 commit into from
May 20, 2022
Merged

Add wildcard import for Helpers in ScalaFunctionalTestSpec #278

merged 1 commit into from
May 20, 2022

Conversation

Aghmat
Copy link
Contributor

@Aghmat Aghmat commented Jul 21, 2020

Many of the code samples in ScalaFunctionalTestingWithScalaTest use the Helpers implicitly and it would be helpful to include it in the import list as with the ScalaFunctionalTestingWithSpecs2 page

mkurz
mkurz approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mkurz mkurz merged commit e02b04a into playframework:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aghmat @mkurz