Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testServerFactory method in BaseOneServer traits #410

Merged
merged 1 commit into from
May 31, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Apr 7, 2023

@mkurz
Copy link
Member

mkurz commented Apr 7, 2023

Thanks, will take a look later. This port thing needs a bit more attention from my side, I don't want to blindly merge this.

@mkurz mkurz force-pushed the testServerFactory branch 2 times, most recently from fd8fe9b to b740b64 Compare May 26, 2023 16:21
@mkurz mkurz force-pushed the testServerFactory branch from b740b64 to 1a44a5d Compare May 31, 2023 07:45
@mkurz
Copy link
Member

mkurz commented May 31, 2023

The problem you solve here is now solved by Play itself already by disabling the https port by default.
Please check out xuwei-k/playframework-jdk-20#1 where I fixed your example, it's working now.

Anyway, I adjusted this pull request, so devs are still able to override the TestFactory, it might help in other situations.

@mergify mergify bot merged commit 350794c into playframework:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants