Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems regarding Scala 3 and sourcePositionMapper #498

Open
mkurz opened this issue Mar 28, 2022 · 3 comments
Open

Fix problems regarding Scala 3 and sourcePositionMapper #498

mkurz opened this issue Mar 28, 2022 · 3 comments

Comments

@mkurz
Copy link
Member

mkurz commented Mar 28, 2022

See

Following commit could then be reverted eventually: e892f83
@mkurz mkurz mentioned this issue Mar 28, 2022
Merged
1 task
tototoshi added a commit to tototoshi/zinc that referenced this issue Apr 1, 2022
@tototoshi
Overwrite Problem#rendered with None when source mapping occurs.
7ea103a 
This commit is to improve Twirl's error message with Scala3.
playframework/twirl#498

This pull request makes sbt ignore `Problem#rendered` passed from the compiler  if source mapping is actually performed.
Sbt will display the error message based on the `Position` transformed by source mapping.
When the source mapping is not performed, the message in `Problem#rendered` is displayed as before.
@tototoshi tototoshi mentioned this issue Apr 1, 2022
Merged
@tototoshi
Copy link
Member

The pull request I sent to sbt/zinc has been merged.
Hopefully, the next release will fix the problem.

@mkurz
Copy link
Member Author

mkurz commented Apr 12, 2022

@tototoshi Nice 👍 BTW, did you see sbt/sbt#6868, I didn't look into all of that, however has this something to do with our problem?

@tototoshi
Copy link
Member

Yes, I am interested in this proposal.
I don't think that this proposal can be a solution to our problem with sourcePositionMappers.
However, it will be a help to make Twirl error messages more friendly in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tototoshi @mkurz