Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven Support #584

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Maven Support #584

merged 1 commit into from
Oct 6, 2023

Conversation

alexmihailov
Copy link
Contributor

@alexmihailov alexmihailov commented Jan 19, 2023 •
edited by ihostage
Loading

Fixes #581

@ihostage ihostage self-requested a review January 20, 2023 10:55
@ihostage
Copy link
Member

Thanks, Alex @alexmihailov! I'll review this as soon as possible 😉

@mkurz
Copy link
Member

mkurz commented Jan 20, 2023

@alexmihailov You need to run sbt headerCreateAll to pass the "code style" checks.

@alexmihailov alexmihailov force-pushed the feature/twirl-maven-plugin branch 2 times, most recently from 76cfd62 to 5c286e9 Compare April 21, 2023 12:47
@alexmihailov
Copy link
Contributor Author

Hi @ihostage! I implemented sbt-maven-plugin-plugin to create a maven plugin on sbt. I am rewrote twirl maven plugin. When the review is over, I will release the sbt-maven-plugin-plugin and remove the SNAPSHOT from plugins.sbt

@ihostage ihostage force-pushed the feature/twirl-maven-plugin branch 5 times, most recently from 63b98bf to 150a9f0 Compare September 21, 2023 11:20
@ihostage ihostage marked this pull request as ready for review September 21, 2023 11:29
@ihostage
Copy link
Member

Depends on #676

@ihostage ihostage force-pushed the feature/twirl-maven-plugin branch from 150a9f0 to 7c24d5d Compare September 21, 2023 12:16
@ihostage ihostage force-pushed the feature/twirl-maven-plugin branch 2 times, most recently from 8a1264a to 3292e21 Compare October 6, 2023 21:54
@ihostage ihostage force-pushed the feature/twirl-maven-plugin branch from 3292e21 to 5e54887 Compare October 6, 2023 22:04
@ihostage ihostage requested a review from mkurz October 6, 2023 22:05
@mkurz
Copy link
Member

mkurz commented Oct 6, 2023

Will take a look now.

@ihostage
Copy link
Member

ihostage commented Oct 6, 2023

@mkurz I think we are ready to merge it before final 2.0.0 😉

@mkurz
Copy link
Member

mkurz commented Oct 6, 2023

I will not take time to deep dive into how everything works. I am sure you know what you are doing. For me it's important that the current twirl code does not get broken, this looks good. I may one day take the time to see how the sbt-maven-plugin etc. work, together with the code here.:+1: for adding the docs.

@mkurz mkurz merged commit 19ddb2e into playframework:main Oct 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihostage ihostage ihostage approved these changes

@mkurz mkurz Awaiting requested review from mkurz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maven Support
3 participants
@alexmihailov @ihostage @mkurz