Handle hyphens in cover var names when generating cover var names (#12)

please-build · Apr 5, 2022 · 9952601 · 9952601
1 parent 8e2bb39
commit 9952601
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,8 +1,11 @@
+Version 0.2.2
+-------------
+    * Handle hyphens in source file names when generating cover vars
+
 Version 0.2.1
 -------------
     * Make the tool as binary
 
-
 Version 0.2.0
 -------------
     * Improve the way we handle discovering coverage variables #7

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.2.1
+0.2.2
diff --git a/tools/please_go/covervars/cover_vars.go b/tools/please_go/covervars/cover_vars.go
@@ -19,5 +19,7 @@ func GenCoverVars(w io.Writer, importPath string, srcs []string) {
 
 func coverVar(src, importPath string) string {
 	baseName := filepath.Base(src)
-	return fmt.Sprintf("%s=GoCover_%s\n", importPath, strings.ReplaceAll(baseName, ".", "_"))
+	varname := strings.ReplaceAll(baseName, ".", "_")
+	varname = strings.ReplaceAll(varname, "-", "_")
+	return fmt.Sprintf("%s=GoCover_%s\n", importPath, varname)
 }