Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic if not given a module version #243

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Don't panic if not given a module version #243

merged 1 commit into from
Mar 13, 2024

Conversation

peterebden
Copy link
Contributor

Now outputs

2024/03/04 16:35:25 Module spec github.com/redis/go-redis/v9 is missing a version; must be in the format golang.org/x/sys@v1.0.0

Fixes #238

@peterebden peterebden merged commit 0e54822 into please-build:master Mar 13, 2024
4 checks passed
@peterebden peterebden deleted the please-go-dont-panic branch March 13, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwestmoreland samwestmoreland samwestmoreland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please_go tool panics when no version is supplied
2 participants
@peterebden @samwestmoreland