Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove options struct for the deleted "get" subcommand. #309

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Remove options struct for the deleted "get" subcommand. #309

merged 2 commits into from
Nov 26, 2024

Conversation

timburks
Copy link
Contributor

@timburks timburks commented Nov 26, 2024 •
edited
Loading

This fixes the crash that I noted in #308

cc @Tatskaari @toastwaffle

toastwaffle
toastwaffle approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@toastwaffle toastwaffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry about that!

Do you want to add a patch version bump to this PR and an entry in the changelog so this is released immediately?

@timburks
Copy link
Contributor Author

@toastwaffle I think I've done that now, thanks for taking this!

@toastwaffle toastwaffle merged commit d02d248 into please-build:master Nov 26, 2024
5 checks passed
@toastwaffle
Copy link
Contributor

Thank you for fixing this!

@timburks timburks deleted the remove-goget branch November 26, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toastwaffle toastwaffle toastwaffle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timburks @toastwaffle