Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Refactor tiptap ReactNodeViewRenderer #443

Closed
Darmody opened this issue Jul 21, 2022 · 0 comments · Fixed by #463
Closed

Refactor tiptap ReactNodeViewRenderer #443

Darmody opened this issue Jul 21, 2022 · 0 comments · Fixed by #463
Assignees
@Darmody
Labels
richtext Related to the rich text editor module tech-debt We should rework on this

Comments

@Darmody
Copy link
Contributor

Darmody commented Jul 21, 2022

Is your feature request related to a problem?

截屏2022-07-21 15 49 33

The image above shows the structure if we create a react node view for the paragraph. It should be as simple as just a <p> tag.

Describe the solution you'd like

Refactor ReactNodeViewRenderer NodeViewWrapper NodeViewContent

Describe alternatives you've considered

No.

Additional context

No response
@Darmody Darmody added the tech-debt We should rework on this label Jul 21, 2022
@Darmody Darmody self-assigned this Jul 21, 2022
@stackia stackia added the richtext Related to the rich text editor module label Jul 21, 2022
@Darmody Darmody mentioned this issue Jul 22, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Darmody Darmody

Labels
richtext Related to the rich text editor module tech-debt We should rework on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor react node view pleisto/mashcard
2 participants
@stackia @Darmody