Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Refactor react node view #463

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Refactor react node view #463

merged 1 commit into from
Jul 26, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 22, 2022

resolve #443

  1. creates a new react node view in editor.
  2. makes Tiptap react renderer and react node view legacy in legacy-editor.
  3. makes DOM construct simple for NodeViewContent.
  4. keeps SubpageMenu using LegacyReactNodeViewRenderer because it will be a deprecated block soon.
  5. keeps SpreadsheetBlock using LegacyReactNodeViewRenderer because of style is broken. @aligo please help me migrate it.
  6. remains top-level container DOM, because it is necessary for React SyntheticEvent

@Darmody Darmody temporarily deployed to pr_preview July 22, 2022 15:42 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr463.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@Darmody Darmody temporarily deployed to pr_preview July 22, 2022 15:58 Inactive
@Darmody Darmody temporarily deployed to pr_preview July 24, 2022 16:34 Inactive
@Darmody Darmody temporarily deployed to pr_preview July 25, 2022 05:26 Inactive
@Darmody Darmody marked this pull request as ready for review July 25, 2022 07:51
@Darmody Darmody requested a review from toadfanszz as a code owner July 25, 2022 07:51
@Darmody Darmody force-pushed the refactor-react-node-view branch 2 times, most recently from 8d76a5c to 463e4eb Compare July 25, 2022 07:53
@Darmody Darmody temporarily deployed to pr_preview July 25, 2022 08:01 Inactive
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #463 (d17d042) into main (c92d139) will decrease coverage by 0.36%.
The diff coverage is 43.78%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   69.82%   69.45%   -0.37%     
==========================================
  Files        1064     1067       +3     
  Lines       18123    18301     +178     
  Branches     2519     2552      +33     
==========================================
+ Hits        12654    12711      +57     
- Misses       5155     5271     +116     
- Partials      314      319       +5     
Flag Coverage Δ
frontend-unit 65.13% <43.78%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/blockViews/ListView/ListView.style.ts 100.00% <ø> (ø)
...legacy-editor/src/tiptapRefactor/ReactNodeView.tsx 13.38% <13.38%> (ø)
...ponents/blockViews/CodeBlockView/CodeBlockView.tsx 72.09% <66.66%> (+0.66%) ⬆️
packages/editor/src/ReactNodeVew/ReactNodeView.tsx 90.90% <90.90%> (ø)
...ages/editor/src/ReactNodeVew/NodeViewContainer.tsx 100.00% <100.00%> (ø)
...nents/blockViews/BlockquoteView/BlockquoteView.tsx 91.66% <100.00%> (+0.75%) ⬆️
.../components/blockViews/CalloutView/CalloutView.tsx 100.00% <100.00%> (ø)
...blockViews/CodeBlockView/styles/highlight.style.ts 100.00% <100.00%> (ø)
.../components/blockViews/HeadingView/HeadingView.tsx 100.00% <100.00%> (ø)
...or/src/components/blockViews/ListView/ListView.tsx 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92d139...d17d042. Read the comment docs.

@stackia stackia merged commit 63fb1b5 into main Jul 26, 2022
@stackia stackia deleted the refactor-react-node-view branch July 26, 2022 06:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor tiptap ReactNodeViewRenderer
3 participants