Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

fix(editor): fix text won't be selected when start dragging behind an inline block #439

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 21, 2022

fix text won't be selected when start dragging behind an inline block.

fix #227

@Darmody Darmody requested a review from toadfanszz as a code owner July 21, 2022 07:03
@Darmody Darmody changed the title fix(editor): fix text won't be selected when start dragging behind an fix(editor): fix text won't be selected when start dragging behind an inline block Jul 21, 2022
@Darmody Darmody force-pushed the fix-inline-block-text-select branch from fb07e74 to 1df7e86 Compare July 21, 2022 07:14
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #439 (1df7e86) into main (700eaab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   69.70%   69.70%           
=======================================
  Files        1060     1060           
  Lines       18015    18015           
  Branches     2490     2490           
=======================================
  Hits        12558    12558           
  Misses       5143     5143           
  Partials      314      314           
Flag Coverage Δ
frontend-unit 65.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/editors/documentEditor/documentEditor.style.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700eaab...1df7e86. Read the comment docs.

@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr439.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@Darmody Darmody merged commit 17702b6 into main Jul 21, 2022
@Darmody Darmody deleted the fix-inline-block-text-select branch July 21, 2022 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A inline block without a space at the end will not be selected by dragging and dropping
2 participants