Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

fix(formula): keep correct formula id #448

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Conversation

toadfanszz
Copy link
Contributor

Keep correct formulaId when rerender.

@toadfanszz toadfanszz marked this pull request as draft July 21, 2022 09:33
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #448 (34d91d5) into main (93e11de) will increase coverage by 0.00%.
The diff coverage is 62.50%.

@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   69.69%   69.70%           
=======================================
  Files        1060     1060           
  Lines       18019    18027    +8     
  Branches     2493     2495    +2     
=======================================
+ Hits        12559    12565    +6     
- Misses       5147     5151    +4     
+ Partials      313      311    -2     
Flag Coverage Δ
frontend-unit 65.35% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/formula/src/context/context.ts 77.77% <0.00%> (-0.80%) ⬇️
packages/formula/src/type/index.ts 100.00% <ø> (ø)
...ts/blockViews/Spreadsheet/SpreadsheetBlockView.tsx 31.57% <0.00%> (-1.02%) ⬇️
...ponents/blockViews/Spreadsheet/SpreadsheetCell.tsx 10.52% <ø> (ø)
...ts/blockViews/Spreadsheet/useFormulaSpreadsheet.ts 80.64% <66.66%> (-1.18%) ⬇️
...omponents/blockViews/Spreadsheet/useSpreadsheet.ts 30.83% <77.77%> (+3.39%) ⬆️
packages/formula/src/context/variable.ts 82.14% <100.00%> (ø)
...extensions/blocks/horizontalRule/horizontalRule.ts 81.81% <0.00%> (ø)
...docId/_shared/DocumentEditor/useDocSyncProvider.ts 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e11de...34d91d5. Read the comment docs.

@toadfanszz toadfanszz temporarily deployed to pr_preview July 21, 2022 09:45 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr448.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@toadfanszz toadfanszz merged commit e4f0ad0 into main Jul 21, 2022
@toadfanszz toadfanszz deleted the fix-formula-spreadsheet branch July 21, 2022 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants