Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

test(formula): refactor codeFragment cache && speed up event test #482

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

toadfanszz
Copy link
Contributor

@toadfanszz toadfanszz commented Jul 26, 2022

Signed-off-by: clszzyh <clszzyh@gmail.com>
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #482 (bb3438d) into main (dc1e575) will decrease coverage by 0.04%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   69.41%   69.37%   -0.05%     
==========================================
  Files        1070     1070              
  Lines       18416    18418       +2     
  Branches     2572     2573       +1     
==========================================
- Hits        12783    12777       -6     
- Misses       5314     5325      +11     
+ Partials      319      316       -3     
Flag Coverage Δ
frontend-unit 65.05% <14.28%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/formula/src/type/index.ts 100.00% <ø> (ø)
.../components/ui/Formula/Preview/FunctionPreview.tsx 72.72% <ø> (ø)
packages/formula/src/context/context.ts 74.62% <7.69%> (-4.17%) ⬇️
...rc/tests/feature/event/spreadsheetDeadlockEvent.ts 100.00% <100.00%> (ø)
packages/formula/src/grammar/codeFragment.ts 92.35% <0.00%> (-0.64%) ⬇️
packages/formula/src/context/variable.ts 84.30% <0.00%> (-0.45%) ⬇️
packages/formula/src/grammar/completer.ts 94.69% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1e575...bb3438d. Read the comment docs.

@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr482.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@stackia stackia merged commit 7cb46df into main Jul 26, 2022
@stackia stackia deleted the formula-test-refactor branch July 26, 2022 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants