Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaussian1d fails if std is an int #265

Closed
billbrod opened this issue Jul 3, 2024 · 0 comments · Fixed by #291
Closed

gaussian1d fails if std is an int #265

billbrod opened this issue Jul 3, 2024 · 0 comments · Fixed by #291
Labels
bug Something isn't working

Comments

@billbrod
Copy link
Collaborator

billbrod commented Jul 3, 2024

Technically, this isn't a bug (since our type-hint does say it only supports float), but gaussian1d will fail if the std is an integer (because we check explicitly for isinstance(std, float) and assume it's a Tensor if not. This is a weird sharp edge, so probably should just call torch.as_tensor on std

@billbrod billbrod added the bug Something isn't working label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant