Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to FrontEnd models #291

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Improvements to FrontEnd models #291

merged 11 commits into from
Sep 5, 2024

Conversation

billbrod
Copy link
Collaborator

@billbrod billbrod commented Sep 3, 2024

This PR includes some small changes to the FrontEnd models and related code:

  • The std arg of gaussian1d can now be an int, and includes more validation
  • Removes width_ratio_limit from CenterSurround, along with clamping behavior. That wasn't working and is only really needed when training the model, which isn't the focus of plenoptic. I think that sort of clamping behavior is better implemented in the training loop
  • All the FrontEnd models have the following changes:
    • Remove width_ratio_limit, as described above
    • kernel_size can be an int or tuple of ints (also in Linear, Gaussian, CenterSurround models)
    • adds bit to documentation describing model name in Berardino's eigendistortion paper
    • Adds pretrained and cache_filt to all models, with parameters from Berardino's thesis (requires kernel_size=31 or kernel_size=(31,31)
  • corrects same_padding type annotations to match behavior
  • adds tests of above behavior

Closes #265, #264

@billbrod billbrod linked an issue Sep 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...enoptic/simulate/canonical_computations/filters.py 100.00% <100.00%> (ø)
src/plenoptic/simulate/models/frontend.py 95.55% <100.00%> (+1.16%) ⬆️
src/plenoptic/simulate/models/naive.py 99.03% <100.00%> (+0.87%) ⬆️
src/plenoptic/tools/conv.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@billbrod billbrod merged commit a51cd75 into main Sep 5, 2024
13 checks passed
@billbrod billbrod deleted the frontend_params branch September 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gaussian1d fails if std is an int clamp in frontend.CenterSurround doesn't work
1 participant