-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steer pyr demo #119
Steer pyr demo #119
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
===========================================
- Coverage 75.42% 27.99% -47.43%
===========================================
Files 33 33
Lines 2629 2568 -61
Branches 526 516 -10
===========================================
- Hits 1983 719 -1264
- Misses 505 1777 +1272
+ Partials 141 72 -69
Continue to review full report at Codecov.
|
converted to PR prematurely. closing for now |
When the dust settles, the only significant change coming from this branch should be the Demo_Steerable_Pyramid.ipynb notebook. That should be relatively stable to the one appearing in this PR, so feel free to glance at the notebook if curious but ignore everything else. |
merging main
…ore runtime friendly
belongs in different PR
ci.yml now handles notebook tests
Questions:
|
I've gone through and edited the text here, take another look at it and tell me what you think. @nikparth can you also take a look at this?
I also pushed some small updates to (unrelated) docstrings, because I noticed them and they were annoying me. And here it is on the readthedocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall this seems fine as a first release. I added some comments on wording in the notebook, but my main comments would be to remove the standard CNN demonstration and comparison to the pyramid. I think it's fine to just show that the pyramid can be added as a module to build on with standard pytorch modules. And then I'd say remove the eigendistortion section as well and we could have another notebook that is about using plenoptic methods with canonical visual models.
because that's how clsases should be named
Demonstrates the use of steer pyr by (1) using it as a front end for a conv net classifier on FashionMNIST and (2) comparing the eigendistortions w/ a baseline classifier that doesn't use a steer pyr frontend.