Deprecations #288
Merged
Deprecations #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some docstrings needed a Notes section added, which is necessary for the @deprecated to render correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates a handful of functions and classes that are no longer useful, as well as removing a handful of imports that weren't being used and commented-out code.
Most importantly, this removes the
Geodesicclass, because it's not as finished / reliable / robust as the other synthesis methods. It has been moved to a separate repo, where we can continue to work on it. That repo also includes the changes from thegeodesics_improvementandpolarbranches, which I'm going to delete after merging this.This removes all mentions of geodesics from the documentation, but not the tests -- those will get removed when the class is removed from the package entirely.
These will all be removed in a future update.