Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: eslint no unused expressions #953

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

ksted
Copy link
Contributor

@ksted ksted commented Jan 14, 2025

Why:

Follow-up to #876

Describe your changes

  • Updates configuration for @typescript-eslint/no-unused-expressions to allow ternary expressions
  • Updates the category page object in the e2e test suite to use getters in a consistent way

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@ksted ksted marked this pull request as ready for review January 14, 2025 07:20
@ksted ksted requested a review from a team as a code owner January 14, 2025 07:20
@ksted ksted enabled auto-merge (squash) January 14, 2025 07:20
@ksted ksted merged commit 533aef5 into main Jan 14, 2025
11 of 12 checks passed
@ksted ksted deleted the refactor/eslint-no-unused-expressions branch January 14, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants