Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eslint no unused vars #956

Merged
merged 2 commits into from
Jan 14, 2025
Merged

refactor: eslint no unused vars #956

merged 2 commits into from
Jan 14, 2025

Conversation

ksted
Copy link
Contributor

@ksted ksted commented Jan 14, 2025 •
edited
Loading

Why:

Follow-up to #876

Describe your changes

  • Enables no-unused-vars rule
  • Removes unused variables
  • Removes commented out e2e tests

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@ksted ksted marked this pull request as ready for review January 14, 2025 12:23
@ksted ksted requested a review from a team as a code owner January 14, 2025 12:23
@ksted ksted enabled auto-merge (squash) January 14, 2025 12:23
@ksted ksted merged commit 1f9158b into main Jan 14, 2025
11 of 12 checks passed
@ksted ksted deleted the refactor/eslint-no-unused-vars branch January 14, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxiroellplenty maxiroellplenty maxiroellplenty approved these changes

Assignees

@ksted ksted

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksted @maxiroellplenty