Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: eslint arrow parens #970

Merged
merged 2 commits into from
Jan 21, 2025
Merged

refactor: eslint arrow parens #970

merged 2 commits into from
Jan 21, 2025

Conversation

ksted
Copy link
Contributor

@ksted ksted commented Jan 21, 2025

Why:

Follow-up to #876

Describe your changes

  • Enables the arrow-parens rule. According to the rules documentation, always should be the default option, but it ended up behaving in unexpected ways without specifying.
  • Adds all missing arrow parentheses.

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@ksted ksted marked this pull request as ready for review January 21, 2025 06:57
@ksted ksted requested a review from a team as a code owner January 21, 2025 06:57
@ksted ksted enabled auto-merge (squash) January 21, 2025 06:57
@ksted ksted merged commit 1549fe6 into main Jan 21, 2025
11 of 12 checks passed
@ksted ksted deleted the refactor/eslint-arrow-parens branch January 21, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants