Unlink build and release workflows from internal distribution process #261
Conversation
| # Run Detekt | ||
| - name: Run Detekt | ||
| continue-on-error: true | ||
| if: ${{ github.ref == 'refs/heads/main' }} | ||
| run: ./gradlew detekt --stacktrace | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GH_REGISTRY_GRADLE_TOKEN }} | ||
| GRADLE_READ_KEY: ${{ secrets.GH_REGISTRY_GRADLE_TOKEN }} | ||
| JOB_RUNR_REPO_PASSWORD: ${{ secrets.JOB_RUNR_REPO_PASSWORD }} | ||
|
|
||
| # Publish Detekt results to GitHub. | ||
| - name: Publish Detekt SARIF report to GitHub | ||
| continue-on-error: true | ||
| if: ${{ github.ref == 'refs/heads/main' }} | ||
| uses: github/codeql-action/upload-sarif@d39d31e687223d841ef683f52467bd88e9b21c14 # v3 | ||
| with: | ||
| sarif_file: build/reports/detekt/detekt.sarif | ||
|
|
There was a problem hiding this comment.
Those reports are not in use.
| @@ -413,291 +409,3 @@ jobs: | |||
| SLACK_USERNAME: GitHub Actions | |||
| SLACK_ICON_EMOJI: ":crashingrocket:" | |||
| SLACK_FOOTER: "" | |||
|
|
|||
| publish-docker-image: | |||
There was a problem hiding this comment.
We don't need to publish a Docker image from the library.
.github/workflows/release.yaml
Outdated
| echo "deploymentEnabled=${{ env.deploymentEnabled }}" >> "$GITHUB_OUTPUT" | ||
| echo "environmentTenant=${{ env.environmentTenant }}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| wiz-cli: |
There was a problem hiding this comment.
There is now no image to scan.
| deps_policy: Pleo-Default-vulnerabilities-policy | ||
| secrets: inherit | ||
|
|
||
| trigger-deploy-gitops-product-dev: |
There was a problem hiding this comment.
There is now no deployment to trigger.
…ld-and-release-workflows-for-prop
|
@dpotyralski Is this a copy-paste from the new cicd workflow, or you manipulated the files that exist here? I think there are 2 "safe" options. Either keep everything as it is and simply remove these files from templates.yaml, or copy-paste the one from reuseble-workflows. If we try to adjust the workflows that exist here, we might face some issues, because there is no easy way to test them |
Those existing ones were distributed here from our templates, so are having the latest changes. I've decided to additionally clean them up from functionalities, which are not longer relevant. |
|
Hey @pleo-io/team-invoices, would appreciate your eyes on this one 🙏 |
dpotyralski
deleted the
feature/devx-2677-create-a-repo-specific-build-and-release-workflows-for-prop
branch
Due to internal changes with GitHub workflows and the missing possibility to utilise reusable workflows from private repositories. Right now it has been decided to unlink the existing workflows from
centralized-templatesand make those currently existing ones repository-specific.Linear story: DEVX-2677
Have you done ...