Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting disk usage details #54

Merged
merged 4 commits into from
Mar 4, 2019
Merged

Getting disk usage details #54

merged 4 commits into from
Mar 4, 2019

Conversation

baldhead
Copy link
Contributor

@baldhead baldhead commented Feb 6, 2019

This may help #24

Copy link
Contributor

@mrsombre mrsombre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review formatting issues

@@ -2,6 +2,7 @@
// Copyright 1999-2019. Plesk International GmbH.

namespace PleskX\Api\Operator;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove white-space change

@@ -34,7 +35,7 @@ public function getPhysicalHostingDescriptor()
public function create(array $properties, array $hostingProperties = null, $planName = null)
{
$packet = $this->_client->getPacket();
$info = $packet->addChild($this->_wrapperTag)->addChild('add');
$info = $packet->addChild($this->_wrapperTag)->addChild('add');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove white-space change

$items = $this->_getItems(Struct\DiskUsage::class, 'disk_usage', $field, $value);
return reset($items);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove white-space change

@baldhead
Copy link
Contributor Author

Formatting issues should be resolved now.

Copy link
Contributor

@mrsombre mrsombre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check this additions to review

tests/WebspaceTest.php Outdated Show resolved Hide resolved
src/Api/Struct/Webspace/DiskUsage.php Outdated Show resolved Hide resolved
tests/WebspaceTest.php Show resolved Hide resolved
@mrsombre mrsombre merged commit 36c6360 into plesk:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants