SMS-7107: Add fraud_check param support (#218)

* SMS-7107: Add fraud_check param support * Fix make start * Update date
plivo · Oct 23, 2024 · 3581266 · 3581266
1 parent cdde3bf
commit 3581266
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,9 @@
 # Change Log
+## [7.53.1](https://github.com/plivo/plivo-go/tree/v7.53.1) (2024-10-23)
+**Feature - FraudCheck param in Create, Get and List Session**
+- Support for the `fraud_check` parameter in sms verify session request
+- Added support for `fraud_check` in GET and LIST verify session.
+
 ## [7.53.0](https://github.com/plivo/plivo-go/tree/v7.53.0) (2024-10-10)
 **Feature - Dtmf param in Create, Get and List Session**
 - Support for the `dtmf` parameter in voice verify session request

diff --git a/Makefile b/Makefile
@@ -5,7 +5,11 @@ build:
 
 start:
 	docker-compose up --build --remove-orphans --detach
-	docker attach $(shell docker-compose ps -q goSDK)
+	# Wait for the container to be running before attaching
+	@while [ -z "$$(docker-compose ps -q goSDK)" ]; do \
+		sleep 1; \
+	done
+	docker attach $$(docker-compose ps -q goSDK)
 
 test:
 	@[ "${CONTAINER}" ] && \

diff --git a/baseclient.go b/baseclient.go
@@ -13,7 +13,7 @@ import (
 	"github.com/google/go-querystring/query"
 )
 
-const sdkVersion = "7.53.0"
+const sdkVersion = "7.53.1"
 
 const lookupBaseUrl = "lookup.plivo.com"
 

diff --git a/fixtures/verifySessionListResponse.json b/fixtures/verifySessionListResponse.json
@@ -43,13 +43,20 @@
           "recipient": "918707046409",
           "channel": "sms",
           "status": "expired",
-          "count": 1,
+          "count": 2,
           "attempt_details": [
               {
                   "channel": "sms",
                   "attempt_uuid": "237bb45f-6238-40fc-a27e-355dbaa8ec02",
                   "status": "failed",
                   "time": "2023-07-20T07:50:36.623172Z"
+              },
+              {
+                "channel": "sms",
+                "attemp_uuid": "237bb45f-6238-40fc-a27e-355dbaa8ec03",
+                "status": "failed",
+                "time": "2023-07-20T07:50:36.623172Z",
+                "fraud_check": "disabled" 
               }
           ],
           "charges": {
@@ -60,7 +67,12 @@
                       "attempt_uuid": "237bb45f-6238-40fc-a27e-355dbaa8ec02",
                       "channel": "sms",
                       "charge": "0.00000"
-                  }
+                  },
+                  {
+                    "attempt_uuid": "237bb45f-6238-40fc-a27e-355dbaa8ec03",
+                    "channel": "sms",
+                    "charge": "0.00000"
+                }
               ]
           },
           "created_at": "2023-07-20T07:50:36.612725Z",

diff --git a/verify.go b/verify.go
@@ -48,6 +48,7 @@ type AttemptDetails struct {
 	CodeLength  int       `json:"code_length,omitempty"`
 	Time        time.Time `json:"time,omitempty"`
 	Dtmf        *int      `json:"dtmf,omitempty"`
+	FraudCheck  string    `json:"fraud_check,omitempty"`
 }
 
 type Charges struct {
@@ -75,6 +76,7 @@ type SessionCreateParams struct {
 	AppHash    string `json:"app_hash,omitempty"`
 	CodeLength int    `json:"code_length,omitempty"`
 	Dtmf       *int   `json:"dtmf,omitempty"`
+	FraudCheck string `json:"fraud_check,omitempty"`
 }
 
 type SessionCreateResponseBody struct {