#96 - fix call of server handle in Gevents Hub context #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that patch, request handler of the server was executed in Gevents Hub context. Which is wrong, because inside it it is impossible to use Gevent blocking API, and servers handle uses it. This patch fixed it - instead of overriding `do_handle` method, which is not supposed to be overriden, server just uses public interface of StreamServer and passes handle to it's init.
Neurotec
added a commit
to Neurotec/plivoframework
that referenced
this pull request
May 31, 2017
murliwala
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that patch, request handler of the server was executed in
Gevents Hub context. Which is wrong, because inside it it is
impossible to use Gevent blocking API, and servers handle uses it.
This patch fixed it - instead of overriding
do_handlemethod, which is notsupposed to be overriden, server just uses public interface of StreamServer
and passes handle to it's init.
It fixes #96.
Here is the minimal setup, that reproduces this problem:
https://gist.github.com/AndrewPashkin/b6405a1e565885f015c3