Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: d3-migration - breadcrumb navigation #371

Closed
Tracked by #237
SgtPooki opened this issue May 15, 2023 · 1 comment
Closed
Tracked by #237

fix: d3-migration - breadcrumb navigation #371

SgtPooki opened this issue May 15, 2023 · 1 comment
Assignees
@SgtPooki

Comments

@SgtPooki
Copy link
Contributor

SgtPooki commented May 15, 2023 •
edited
Loading

How to reproduce issues:

Browser back is broken

  1. visit http://localhost:3000/roadmap/github.com/ipfs/ipfs-gui/issues/106
  2. click any clickable milestone
  3. click browser back button
  4. notice that rendering doesn't update appropriately.

Breadcrumb renders duplicate titles

  1. visit http://localhost:3000/roadmap/github.com/ipfs/ipfs-gui/issues/106
  2. click any clickable milestone
  3. click browser back button
  4. click browser forward button
  5. click browser back button
  6. Notice duplicate breadcrumb item

image
@SgtPooki SgtPooki mentioned this issue May 15, 2023
Closed
2 tasks
@SgtPooki SgtPooki self-assigned this May 15, 2023
@SgtPooki
Copy link
Contributor Author

seems to be related to

Starmap/components/roadmap/NewRoadmap.tsx

Line 70 in f598b42

window.history.replaceState(null, '', `${window.location.pathname}#${hashParams.toString()}`)

SgtPooki added a commit that referenced this issue May 15, 2023
@SgtPooki
fix: breadcrumb nav & zoomTransform+url bug
fa90f5c 
fixes #371
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) May 16, 2023
SgtPooki added a commit that referenced this issue May 19, 2023
@SgtPooki @whizzzkid
feat!: render roadmaps with d3 (#358)
6c085b3 
* chore: fix error when clicking roadmap item in d3 mode

* chore: render d3 roadmap with correct header

* chore: pull out date logic

* feat: get d3 mode rendering

* chore: ensure today line toggles properly

* chore: roadmap header ticks&labels are rendering

* tmp

* tmp: attempting panning impl and quit. started on collision detection

* chore: expand mode=d3 milestone items width to match text

* chore(d3): start work on collision detection

* feat: bin-packing algorithm implemented for d3 rendering

* feat: bin-packing is working really well

* feat: d3 panning works

* feat: d3 zooming + panning

* fix: d3 roadmap view width

* fix: milestone text

* fix(milestone): d3 rendering is more accurate

* fix(milestone): d3 milestones show progress bar

* fix(milestone): text padding, size, polish, truncating

* fix(drag): prevent unintentional attempt to drag milestone items

* fix: d3 roadmap height + panning and zoom polish

* fix: date granularity upon zooming out

* feat: SERIOUS polish on zoom, pan, & header labels

* tmp: temporarily force rendering of d3 roadmap for preview

* chore: fix build errors

* tmp: temporarily ignore unused RoadmapDetailed

* tmp: dont run tests for d3 preview; for now

* fix: zoom and pan controls are more intuitive

* chore: remove unused component

* fix: tickGuides stretch to full height

* fix: invalid foreignObject usage

* feat: implement detailed view in d3

NOTE: Currently a bug when switching between simple and detailed view

* fix: build

* tmp: using issueData context

* fix: binPackedGroups doesnt cause infinite re-renders

* fix: pan/zoom work when toggling views

* fix: use MMM DD, YYYY display format for milestone dates

* chore: pull out RoadmapGroupRenderer

* chore: fix build, renable tests, skip e2e

* fix: todayLine styling

* chore: remove unused code

* chore: todayLine polish

* chore: some more cleanup

* chore: set ETA always to EOD

* fix: rescale the timeScale with zoom transform

* fix: zoom and panning

* This allows us to properly recognize when an X value is within view
* Removes old hacky way of manually using panX

* feat: make zoom/pan level shareable

* feat: default zoom finding, and url parameter setting

* chore: fix build

* tests: fix unit tests

* fix: default view finding when all dates are same

fixes #369

* fix: d3-migration e2e tests

* fix(lint): remove unused legacyView

* chore: fix next+eslint

* chore: remove dead code

* feat: add legacy view button

* test: remove tests for removed files

* chore(pr-comment): remove redundant null check

* chore(pr-comment): clean up components/roadmap/header.tsx

* chore(pr-comment): move constants to svgConstants

* chore(pr-comment): refactor math into ItemContainerSvg

* chore: implement standard style

* chore(lint): sort imports

* feat: make roadmapHeader smarter

* feat: make roadmapHeader even smarter (mobile support)

* chore(pr-comment): code cleanup

* chore: use Dayjs instead of Date in NewRoadMapHeaderTick

* fix: css on hover for clickable milestones

* chore: remove RoadmapMode and it's uses

* chore: remove unused file

* fix: some viewMode issues

* fix: breadcrumb nav & zoomTransform+url bug

fixes #371

* fix: lint

* fix: 📦 Fixing box model (#375)

* fix: 📦 Fixing box model

* 🤦 lint

* fix: ⚡ reducing number of comparisons

---------

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>

* fix: dont loop over each group of binPackedItems (#376)

* fix: dont loop over each group of binPackedItems

* fix: top/bottom y semantics

* Revert "fix: top/bottom y semantics"

This reverts commit 5d275b3.

---------

Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtPooki