Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license file #327

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Add license file #327

merged 5 commits into from
Mar 28, 2023

Conversation

AlexxNica
Copy link
Collaborator

Fixes #78

@AlexxNica
feat: add LICENSE
ca87240 
Signed-off-by: Alexandre Nicastro <alexandre.nicastro@nikas.org>
@vercel
Copy link

vercel bot commented Feb 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 4:50PM (UTC)

SgtPooki
SgtPooki requested changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be the same as

https://github.com/ipfs/aegir/blob/master/LICENSE-MIT
https://github.com/ipfs/aegir/blob/master/LICENSE
https://github.com/ipfs/aegir/blob/master/LICENSE-APACHE

@AlexxNica
Copy link
Collaborator Author

@SgtPooki it seems the LICENSE-APACHE from that repo doesn't get recognized by GitHub. Should we add a format that gets recognized by GitHub or just ignore it?
image

@SgtPooki
Copy link
Contributor

@SgtPooki it seems the LICENSE-APACHE from that repo doesn't get recognized by GitHub. Should we add a format that gets recognized by GitHub or just ignore it?

Good callout. We should ignore it here, and open an issue on aegir.

@SgtPooki SgtPooki mentioned this pull request Feb 24, 2023
Open
@SgtPooki
Copy link
Contributor

created ipfs/aegir#1198

@AlexxNica AlexxNica mentioned this pull request Feb 27, 2023
Merged
@AlexxNica AlexxNica requested a review from SgtPooki March 13, 2023 22:26
SgtPooki
SgtPooki requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we're still missing the files we should have

@AlexxNica
Copy link
Collaborator Author

looks like we're still missing the files we should have

@SgtPooki aren't those at #338? I believe you have to accept that one so that the updates show up on this PR, since I don't have permission to push to this branch directly.

AlexxNica and others added 2 commits March 28, 2023 09:48
@AlexxNica @SgtPooki
feat(license): move to dual-licensing (MIT/Apache-2.0) (#338)
63ed7d7 
Signed-off-by: Alexandre Nicastro <alexandre.nicastro@nikas.org>
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
@SgtPooki
Merge branch 'main' into add-license-file
f0e205f
@SgtPooki SgtPooki merged commit fa99b19 into main Mar 28, 2023
@SgtPooki SgtPooki deleted the add-license-file branch March 28, 2023 16:51
@SgtPooki SgtPooki mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license files
2 participants
@AlexxNica @SgtPooki