chore: add debug logging for sw #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| async _handle(request: Request, handler: StrategyHandler): Promise<Response | undefined> { | ||
| async _handle(request: Request, handler: StrategyHandler): Promise<Response> { |
There was a problem hiding this comment.
Function _handle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
whizzzkid
approved these changes
May 9, 2023
| @@ -1,6 +1,14 @@ | |||
| /* eslint-disable import/no-unused-modules */ | |||
| import { Strategy, StrategyHandler } from 'workbox-strategies'; | |||
| import Dexie from 'dexie'; | |||
| import debug from 'debug'; | |||
There was a problem hiding this comment.
only if the could have an export for webWorker which would not be based on localStorage sync api.
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localStorage.setItem('debug', <debugString>)method of enabling debugging