Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When displaying differences on a zope.schema.List field, vocabulary terms titles are displayed (if a vocabulary is linked to the field) #34

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

sgeulette
Copy link
Member

Before was displayed the field value... Now the vocabulary term title.
Alse used plone5 in buildout.
Corrected plenty annoying flake8 errors.
Seems plone4 compatible: only tests counting differences are failing because a difference on the 'id' field is not present when using plone 4 plone.app.contenttypes version.

@sgeulette sgeulette requested review from pbauer and jensens October 2, 2018 09:33
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jensens jensens merged commit b683b12 into plone:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants