Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test by explicitly reindexing #89

Merged
merged 1 commit into from
Jul 17, 2022
Merged

fix test by explicitly reindexing #89

merged 1 commit into from
Jul 17, 2022

Conversation

davisagli
Copy link
Member

This reindexing used to be triggered implicitly by creation of a CMF UID while saving the object in portal_repository, but after zopefoundation/Products.CMFUid#21 that no longer includes the SearchableText index.

@mister-roboto
Copy link

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli davisagli force-pushed the davisagli-fix-test branch from 58fa586 to b697cf5 Compare July 17, 2022 00:46
@davisagli
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 7ecb40b into master Jul 17, 2022
@davisagli davisagli deleted the davisagli-fix-test branch July 17, 2022 03:36
mauritsvanrees pushed a commit that referenced this pull request Oct 31, 2022
Backported to 3.x from master from #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants