form.submitted secure deletion #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testing PR here http://jenkins.plone.org/view/All/job/pull-request/142/ |
jensens
added a commit
that referenced
this pull request
May 20, 2015
form.submitted secure deletion
jensens
added a commit
to plone/buildout.coredev
that referenced
this pull request
May 20, 2015
jensens
added a commit
to plone/buildout.coredev
that referenced
this pull request
May 20, 2015
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found this bug in a strange setup:
Plone 4.3.4.1 + uwosh.pfg.d2c (PloneFormGen plugin for storing data in content-types) + a versioned d2c content.
When i submit the form, the process enter 2 times in BaseControllerPageTemplate for the same request. The second time is when is assigned the controller_state.
In this case, the BaseControllerPageTemplate is called another way. The second controller delete correctly the entry in the request, but when we return to the first controller, the entry has already deleted and an exception is raised.
With this simple check we can avoid the problem.