Merge pull request #1963 from plone/remove-highlightsearchterms

fix #1811: Remove last legacy Javascript highlight-searchterms.js

CHANGES.rst

@@ -13,6 +13,191 @@ Breaking changes:
 - Remove all dependencies on plone.app.controlpanel. 
   Third party code need either to depend on plone.app.controlpanel 4.0,
   which is a backward compatibilit package only, or also update to not depend on it anymore.
+- *add item here*
+
+New features:
+
+- Adapt code and tests to the new indexing operations queueing.
+  Part of PLIP 1343: https://github.com/plone/Products.CMFPlone/issues/1343
+  [gforcada]
+
+Bug fixes:
+
+- Show version of products in Add-ons control panel configlet.
+  This fixes https://github.com/plone/Products.CMFPlone/issues/1472.
+- Remove last legacy Javascript ``highlight-searchterms.js``. 
+  Removes also the skins folder ``plone_ecmascript``. 
+  It was broken for almost all use cases (Google, other search engines, own live search);
+  JS worked only when coming from Plone detailed search page.
+  [jensens]
+
+- Get rid of obsolete ``X-UA-Compatible`` header.
+  [hvelarde]
+
+- Resource registry legacy bundle cooking: Exit early with a warning, if preconditions to build are not given (no compilation paths).
+  Allow cooking CSS, even if no JS is defined.
+  Log all important steps of the cooking process.
+  [thet]
+
+- Remove unused ``plone.css`` from static repository.
+  [thet]
+
+- Check for ``AccessInactivePortalContent`` for each path in a catalog query.
+  This solves a problem, where Editors couldn't see inactive content, even though they had the required permission on a subpath of the portal (e.g. a subsite).
+  [thet]
+
+- Remove last legacy Javascript ``highlight-searchterms.js``. 
+  Removes also the skins folder ``plone_ecmascript``. 
+  It was broken for all (Google, other search engines, own live search);
+  JS worked only when coming from Plone detailed search.
+  [jensens]
+
+
+5.1b2 (2017-02-20)
+------------------
+
+Bug fixes:
+
+- Fix packaging error.
+  [esteele]
+
+5.1b1 (2017-02-20)
+------------------
+
+Breaking changes:
+
+- Add helper method to get all catalog entries from a given catalog: ``Products.CMFPlone.CatalogTool.catalog_get_all``.
+  In Products.ZCatalog before 4.0 a catalog call without a query returned all catalog brains.
+  This can be used as a replacement where it is needed, for exampe in tests.
+  [thet, gogobd]
+
+- Remove ``query_request`` from CatalogTool's search method, as it isn't supported in Products.ZCatalog 4 anymore.
+  [thet]
+
+- Removed our patch that added ``secureSend`` to the ``MailHost``.
+  This was originally scheduled for removal in Plone 5.0.  See `issue
+  965 <https://github.com/plone/Products.CMFPlone/issues/965>`_.
+  [maurits]
+
+- The related items widget has changed a lot.
+  See the Mockup changelog for 2.4.0 here: https://github.com/plone/mockup/blob/master/CHANGES.rst
+
+- All css classes named ``enableUnloadProtection`` were changed to ``pat-formunloadalert`` to trigger that pattern.
+  Templates using ``enableUnloadProtection`` should change to ``pat-formunloadalert`` too.
+  This change shouldn't impact too much, because the form unload protection didn't work at all in Plone 5 until now.
+  [thet]
+
+- MimetypesRegistry icons are now a browser resource directory instead of skins folder.
+  [jensens]
+
+- Remove unused ``plone_scripts`` (not used nor tested anywhere in coredev) [jensens, davisagli]
+
+    - ``add_ext_editor.py``
+    - ``author_find_content.py``
+    - ``canSelectDefaultPage.py`` with tests
+    - ``create_query_string.py``
+    - ``createMultiColumnList.py``
+    - ``displayContentsTab.py``
+    - ``formatColumns.py`` with tests
+    - ``getAllowedTypes.py``
+    - ``getGlobalPortalRoles.py``
+    - ``getNotAddableTypes.py``
+    - ``getPopupScript.py``
+    - ``getPortalTypeList.py`` and metadata
+    - ``getPortalTypes.py``
+    - ``getSelectableViews.py`` with tests
+    - ``hasIndexHtml.py`` with tests
+    - ``navigationParent.py`` with test
+    - ``plone_log.py``
+    - ``plone.css.py``
+    - ``returnNone.py`` with occurence refactored
+    - ``reverseList.py`` with test
+    - ``sort_modified_ascending.py``
+
+- Move scripts ``datecomponents.py`` and ``show_id.py`` to Archetypes
+  [jensens, davisagli]
+
+- Remove methods of the ``@@plone`` view that were marked for deprecation:
+  - ``showEditableBorder`` (use ``@@plone/showToolbar``)
+  - ``mark_view`` (use ``@@plone_layout/mark_view``)
+  - ``hide_columns`` (use ``@@plone_layout/hide_columns``)
+  - ``icons_visible`` (use ``@@plone_layout/icons_visible``)
+  - ``getIcon`` (use ``@@plone_layout/getIcon``)
+  - ``have_portlets`` (use ``@@plone_layout/have_portlets``)
+  - ``bodyClass`` (use ``@@plone_layout/bodyClass``)
+  [davisagli]
+
+- Move plone_content skin templates into Products.ATContentTypes as browser views.
+  [gforcada]
+
+New features:
+
+- Added ``ok`` view.  This is useful for automated checks, for example
+  httpok, to see if the site is still available.  It returns the text
+  ``OK`` and sets headers to avoid caching.
+  [maurits]
+
+- Make contact form extensible. This fixes https://github.com/plone/Products.CMFPlone/issues/1879.
+  [timo]
+
+- Don't minify CSS or JavaScript resources if they end with ``.min.css`` resp. ``.min.js``.
+  [thet]
+
+- Add ``safe_encode`` utility function to ``utils`` to safely encode unicode to a specified encoding.
+  The encoding defaults to ``utf-8``.
+  [thet]
+
+- The password reset templates were changed to make use of ``content-core`` macros.
+  [thet]
+
+- Add utility method to retrieve the top most parent request from a sub request.
+  [thet]
+
+- Add ``mockup-patterns-relateditems-upload`` resource, which can be used in custom bundles to add the upload feature in the related items widget.
+  [thet]
+
+- Move ``get_top_site_from_url`` from plone.app.content to ``utils.py`` and make it robust against unicode paths.
+  This function allows in virtual hosting environments to acquire the top most visible portal object to operate on.
+  It is used for example to calculate the correct virtual root objects for Mockup's related items and structure pattern.
+  [thet]
+
+- Add sort_on field to search controlpanel.
+  [rodfersou]
+
+- PLIP 1340: Deprecate portal_quickinstaller.
+  You should no longer use CMFQuickInstallerTool methods, but GenericSetup profiles.
+  See https://github.com/plone/Products.CMFPlone/issues/1340
+  [maurits]
+
+- Include mockup 2.4.0.
+  [thet]
+
+- PasswordResetTool moved from its own package to here (includes cleanup and removal of ``getStats``).
+  [tomgross]
+
+- Prevent workflow menu overflowing in toolbar [MatthewWilkes]
+
+- Add default icon for top-level contentview and contentmenu toolbar entries [alecm]
+
+- Toolbar: Make menu hover background fit whole menu width. [thet]
+
+- Toolbar: Don't force scoll buttons to be left, when toolbar is right. [thet]
+
+- Toolbar: Make first level list items exand the whole toolbar width - also when scroll buttons are shown. [thet]
+
+- Toolbar: Make scroll buttons exand whole toolbar width. [thet]
+
+- Toolbar: Let the toolbar submenus be as wide as they need to be and do not break entries into multiple lines. [thet]
+
+- Resource Registry:
+  In ``debug-mode`` (zope.conf, buildout) do not load cache the production bundle.
+  [jensens]
+
+- Resource Registry:
+  In ``debug-mode`` (zope.conf, buildout) do not ignore development mode for anonymous users.
+  [jensens]
+
+- Resource Registry: If file system version is newer than ``last_compilation`` date of a bundle, use this as ``last_compilation`` date.
   [jensens]
 
 - New browser view based login code - merged from plone.login (credits to esteele, pbauer, agitator, jensens, et al).

Products/CMFPlone/profiles/default/skins.xml

@@ -3,8 +3,6 @@
    cookie_persistence="False" default_skin="Plone Default"
    request_varname="plone_skin">
  <object name="custom" meta_type="Folder"/>
- <object name="plone_ecmascript" meta_type="Filesystem Directory View"
-    directory="Products.CMFPlone:skins/plone_ecmascript"/>
  <object name="plone_form_scripts" meta_type="Filesystem Directory View"
     directory="Products.CMFPlone:skins/plone_form_scripts"/>
  <object name="plone_images" meta_type="Filesystem Directory View"
@@ -19,7 +17,6 @@
     directory="Products.CMFPlone:skins/plone_wysiwyg"/>
  <skin-path name="Plone Default">
   <layer name="custom"/>
-  <layer name="plone_ecmascript"/>
   <layer name="plone_wysiwyg"/>
   <layer name="plone_prefs"/>
   <layer name="plone_templates"/>

Products/CMFPlone/profiles/dependencies/registry.xml

@@ -1071,14 +1071,8 @@
       <value key="js">++plone++static/components/jquery.recurrenceinput.js/lib/jquery.tmpl.js</value>
       <value key="deps">jquery</value>
   </records>
-  <!-- legacy js -->
-
-
-  <records prefix="plone.resources/jquery-highlightsearchterms"
-            interface='Products.CMFPlone.interfaces.IResourceRegistry'>
-      <value key="js">jquery.highlightsearchterms.js</value>
-  </records>
-
+
+<!-- legacy js -->
   <record name="plone.resources.last_legacy_import">
     <field type="plone.registry.field.Datetime">
       <title>Last legacy js/css import date</title>
@@ -1230,7 +1224,6 @@
             interface='Products.CMFPlone.interfaces.IBundleRegistry'>
     <value key="merge_with">default</value>
     <value key="resources" purge="false">
-      <element>jquery-highlightsearchterms</element>
     </value>
     <value key="depends">plone</value>
     <value key="jscompilation">++plone++static/plone-legacy-compiled.js</value>