Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new portal_type to types_not_searched fails #1118

Closed
mauritsvanrees opened this issue Sep 30, 2015 · 0 comments
Closed

Adding new portal_type to types_not_searched fails #1118

mauritsvanrees opened this issue Sep 30, 2015 · 0 comments
Labels
01 type: bug

Comments

@mauritsvanrees
Copy link
Member

I am trying this in PloneFormGen, moving types_not_searched from portal_properties to the registry. It fails with a ConstraintNotSatisfied: FormSelectionField. This is because the types_not_searched setting has a vocabulary that contains the currently defined types. And FormSelectionField is not in that list because the PloneFormGen profile is being applied right now and its typeinfo step has not been applied yet.

Most obvious solution would be to add typeinfo to the dependencies of the plone.app.registry import step. That solves it, though I wonder if the changed import step order has negative side effects. And I wonder if other steps need to be added to the dependency list too.

I'll open a pull request for plone.app.registry.
mauritsvanrees added a commit to plone/plone.app.registry that referenced this issue Sep 30, 2015
@mauritsvanrees
Let our plone.app.registry import step depend on typeinfo.
476e8d7 
The portal types may be needed for vocabularies.  For example, you
could get an error when adding a not yet installed type to
`types_not_searched`.

Fixes plone/Products.CMFPlone#1118
@mauritsvanrees mauritsvanrees mentioned this issue Sep 30, 2015
Merged
mauritsvanrees added a commit to plone/plone.app.registry that referenced this issue Oct 6, 2015
@mauritsvanrees @jensens
Let our plone.app.registry import step depend on typeinfo.
88d709c 
The portal types may be needed for vocabularies.  For example, you
could get an error when adding a not yet installed type to
`types_not_searched`.

Fixes plone/Products.CMFPlone#1118
jensens added a commit to plone/buildout.coredev that referenced this issue Oct 6, 2015
@jensens
[fc] Repository: plone.app.registry
9fe1aa5 
Branch: refs/heads/master
Date: 2015-10-06T12:19:52+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.registry@88d709c

Let our `plone.app.registry` import step depend on `typeinfo`.

The portal types may be needed for vocabularies.  For example, you
could get an error when adding a not yet installed type to
`types_not_searched`.

Fixes plone/Products.CMFPlone#1118

Files changed:
M CHANGES.rst
M plone/app/registry/exportimport/configure.zcml
Repository: plone.app.registry
Branch: refs/heads/master
Date: 2015-10-06T12:24:10+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.registry@248b307

Merge pull request #9 from plone/maurits-depend-typeinfo

Let our `plone.app.registry` import step depend on `typeinfo`.

Files changed:
M CHANGES.rst
M plone/app/registry/exportimport/configure.zcml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jensens @mauritsvanrees