Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecated geticon ... code #1151

Closed
fgrcon opened this issue Oct 11, 2015 · 7 comments
Closed

Cleanup deprecated geticon ... code #1151

fgrcon opened this issue Oct 11, 2015 · 7 comments

Comments

@fgrcon
Copy link
Member

fgrcon commented Oct 11, 2015

Plone 5 renders contenttype icons with css classes (using fontello). There is a lot of sourcecode to be cleaned up. Old style icons are rendered together with fontello icons.

double-icons

see also #1074 and discussions in plone/plone.app.content#57

@fgrcon
Copy link
Member Author

fgrcon commented Oct 14, 2015

results so far (some new or updated prs will follow soon):
dexterity-types
portlets kopie
related-items-view
reviewlist
search

sitemap

@fgrcon
Copy link
Member Author

fgrcon commented Oct 14, 2015

@vangheem, @jensens, @pbauer, @thet .... and all who are interested:

this should be finished (preliminary, I hope i ditn't forget a pr),

the prs related and to merge (if you dare 😟 ) are:


  • there is still a lot of legacy code to be cleaned up. I did not really dare. ...
  • the bullets in some portlets should be removed - together with icons they look very ugly.
  • some more minor things ...

I hope you are not to much annoyed by all the nuissance i caused as a plone newbie,
Franz

vangheem added a commit to plone/buildout.coredev that referenced this issue Oct 15, 2015
Branch: refs/heads/master
Date: 2015-10-14T21:35:11+02:00
Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net>
Commit: plone/plone.app.layout@5dfcb29

fix icon rendering ...
  plone/Products.CMFPlone#1151

Files changed:
M CHANGES.rst
M plone/app/layout/globals/interfaces.py
M plone/app/layout/viewlets/document_relateditems.pt
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2015-10-14T21:55:00-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.layout@1441bd9

Merge pull request #67 from fgrcon/master

fix icon rendering ...

Files changed:
M CHANGES.rst
M plone/app/layout/globals/interfaces.py
M plone/app/layout/viewlets/document_relateditems.pt
@jensens
Copy link
Member

jensens commented Oct 15, 2015

nobody is annoyed! its the opposite, thank you very much for the contribution. We are at the moment at plone conference and may find time to review and merge at the sprint. please stay tuned.

PS.: I updated your list so it links to the PRs

@cleder
Copy link

cleder commented Oct 15, 2015

Thanks, Great work, and Great documentation, I love the images pointing out
what was adressed :-)

On 15 October 2015 at 10:56, Jens W. Klein notifications@github.com wrote:

nobody is annoyed! its the opposite, thank you very much for the
contribution. We are at the moment at plone conference and may find time to
review and merge at the sprint. please stay tuned.


Reply to this email directly or view it on GitHub
#1151 (comment)
.

Best Regards,

Christian Ledermann

Newark-on-Trent - UK
Mobile : +44 7474997517

https://uk.linkedin.com/in/christianledermann
https://github.com/cleder/

<*)))>{

If you save the living environment, the biodiversity that we have left,
you will also automatically save the physical environment, too. But If
you only save the physical environment, you will ultimately lose both.

  1. Don’t drive species to extinction

  2. Don’t destroy a habitat that species rely on.

  3. Don’t change the climate in ways that will result in the above.

}<(((*>

vangheem added a commit to plone/buildout.coredev that referenced this issue Oct 17, 2015
Branch: refs/heads/master
Date: 2015-10-14T23:06:11+02:00
Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net>
Commit: plone/plone.app.querystring@09dec41

fix resultview icons, plone/Products.CMFPlone#1151

Files changed:
M CHANGES.rst
M plone/app/querystring/results.pt
Repository: plone.app.querystring
Branch: refs/heads/master
Date: 2015-10-17T04:51:48-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.querystring@df50674

Merge pull request #55 from fgrcon/master

fix resultview icons,…

Files changed:
M CHANGES.rst
M plone/app/querystring/results.pt
@vangheem
Copy link
Member

So I merged a few; however, I'm not sure how this affects plone.app.contenttypes which I think is still meant to work with Plone 5.

fgrcon added a commit to plone/plone.app.querystring that referenced this issue Oct 18, 2015
fgrcon added a commit to plone/buildout.coredev that referenced this issue Oct 18, 2015
Branch: refs/heads/master
Date: 2015-10-18T12:15:22+02:00
Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net>
Commit: plone/plone.app.querystring@295a317

update: fixed resultsview according to plone/Products.CMFPlone#1151

Files changed:
M plone/app/querystring/results.pt
@fgrcon
Copy link
Member Author

fgrcon commented Oct 18, 2015

updated search results: show thumbs for images and lead-images
searchresults-updated

gforcada added a commit to plone/buildout.coredev that referenced this issue Oct 18, 2015
Branch: refs/heads/master
Date: 2015-10-16T14:12:23+02:00
Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net>
Commit: plone/plone.app.dexterity@c9239c4

fix icons in dexterity types list
plone/Products.CMFPlone#1151
plone/Products.CMFPlone#1013

Files changed:
M plone/app/dexterity/browser/types_listing_row.pt
Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2015-10-16T14:14:35+02:00
Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net>
Commit: plone/plone.app.dexterity@4759d75

changenote #1151

Files changed:
M CHANGES.rst
Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2015-10-19T00:08:00+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/plone.app.dexterity@d4d4729

Merge pull request #188 from fgrcon/master

fix icons in dexterity types list

Files changed:
M CHANGES.rst
M plone/app/dexterity/browser/types_listing_row.pt
@fgrcon
Copy link
Member Author

fgrcon commented Nov 5, 2015

I am going to start to cleanup and rework this and related issues.
see #1226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants