-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup deprecated geticon ... code #1151
Comments
@vangheem, @jensens, @pbauer, @thet .... and all who are interested: this should be finished (preliminary, I hope i ditn't forget a pr),the prs related and to merge (if you dare 😟 ) are:
I hope you are not to much annoyed by all the nuissance i caused as a plone newbie, |
Branch: refs/heads/master Date: 2015-10-14T21:35:11+02:00 Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net> Commit: plone/plone.app.layout@5dfcb29 fix icon rendering ... plone/Products.CMFPlone#1151 Files changed: M CHANGES.rst M plone/app/layout/globals/interfaces.py M plone/app/layout/viewlets/document_relateditems.pt Repository: plone.app.layout Branch: refs/heads/master Date: 2015-10-14T21:55:00-05:00 Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com> Commit: plone/plone.app.layout@1441bd9 Merge pull request #67 from fgrcon/master fix icon rendering ... Files changed: M CHANGES.rst M plone/app/layout/globals/interfaces.py M plone/app/layout/viewlets/document_relateditems.pt
nobody is annoyed! its the opposite, thank you very much for the contribution. We are at the moment at plone conference and may find time to review and merge at the sprint. please stay tuned. PS.: I updated your list so it links to the PRs |
Thanks, Great work, and Great documentation, I love the images pointing out On 15 October 2015 at 10:56, Jens W. Klein notifications@github.com wrote:
Best Regards, Christian Ledermann Newark-on-Trent - UK https://uk.linkedin.com/in/christianledermann <*)))>{ If you save the living environment, the biodiversity that we have left,
}<(((*> |
Branch: refs/heads/master Date: 2015-10-14T23:06:11+02:00 Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net> Commit: plone/plone.app.querystring@09dec41 fix resultview icons, plone/Products.CMFPlone#1151 Files changed: M CHANGES.rst M plone/app/querystring/results.pt Repository: plone.app.querystring Branch: refs/heads/master Date: 2015-10-17T04:51:48-05:00 Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com> Commit: plone/plone.app.querystring@df50674 Merge pull request #55 from fgrcon/master fix resultview icons,… Files changed: M CHANGES.rst M plone/app/querystring/results.pt
So I merged a few; however, I'm not sure how this affects plone.app.contenttypes which I think is still meant to work with Plone 5. |
Branch: refs/heads/master Date: 2015-10-18T12:15:22+02:00 Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net> Commit: plone/plone.app.querystring@295a317 update: fixed resultsview according to plone/Products.CMFPlone#1151 Files changed: M plone/app/querystring/results.pt
Branch: refs/heads/master Date: 2015-10-16T14:12:23+02:00 Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net> Commit: plone/plone.app.dexterity@c9239c4 fix icons in dexterity types list plone/Products.CMFPlone#1151 plone/Products.CMFPlone#1013 Files changed: M plone/app/dexterity/browser/types_listing_row.pt Repository: plone.app.dexterity Branch: refs/heads/master Date: 2015-10-16T14:14:35+02:00 Author: Franz Gerhard Reinisch (fgrcon) <franz@fgrcon.net> Commit: plone/plone.app.dexterity@4759d75 changenote #1151 Files changed: M CHANGES.rst Repository: plone.app.dexterity Branch: refs/heads/master Date: 2015-10-19T00:08:00+02:00 Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de> Commit: plone/plone.app.dexterity@d4d4729 Merge pull request #188 from fgrcon/master fix icons in dexterity types list Files changed: M CHANGES.rst M plone/app/dexterity/browser/types_listing_row.pt
I am going to start to cleanup and rework this and related issues. |
Plone 5 renders contenttype icons with css classes (using fontello). There is a lot of sourcecode to be cleaned up. Old style icons are rendered together with fontello icons.
see also #1074 and discussions in plone/plone.app.content#57
The text was updated successfully, but these errors were encountered: